Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_storagegateway_gateway: Add SMB settings arguments #5269

Merged
merged 1 commit into from
Aug 2, 2018
Merged

resource/aws_storagegateway_gateway: Add SMB settings arguments #5269

merged 1 commit into from
Aug 2, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 20, 2018 •
edited
Loading

Reference: #943

Changes proposed in this pull request:

  • Add smb_active_directory_settings nested argument for joining gateway to Active Directory domain
  • Add smb_guest_password for setting smbguest password

Output from acceptance testing:

8 tests passed (all tests)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (218.80s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (219.81s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (228.91s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (235.57s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (245.08s)
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (261.42s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (263.58s)
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (645.19s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 20, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 20, 2018
@bflad bflad force-pushed the f-aws_storagegateway_gateway-smb_guest_password branch from 9b192e9 to 720a44d Compare July 20, 2018 13:30
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 20, 2018
@bflad bflad requested a review from a team July 20, 2018 14:03
This was referenced Jul 20, 2018
Merged
Closed
@bflad bflad force-pushed the f-aws_storagegateway_gateway-smb_guest_password branch from 720a44d to b036869 Compare July 27, 2018 19:56
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 27, 2018
appilon
appilon approved these changes Aug 2, 2018
View reviewed changes
aws/resource_aws_storagegateway_gateway.go
@@ -20,6 +21,11 @@ func resourceAwsStorageGatewayGateway() *schema.Resource {
Read: resourceAwsStorageGatewayGatewayRead,
Update: resourceAwsStorageGatewayGatewayUpdate,
Delete: resourceAwsStorageGatewayGatewayDelete,
CustomizeDiff: customdiff.Sequence(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forces new when nested "smb_active_directory_settings" is removed, am I interpreting correctly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the docs makes this crystal clear

@bflad bflad added this to the v1.31.0 milestone Aug 2, 2018
@bflad bflad merged commit 3befbfd into master Aug 2, 2018
@bflad bflad deleted the f-aws_storagegateway_gateway-smb_guest_password branch August 2, 2018 22:33
bflad added a commit that referenced this pull request Aug 2, 2018
@bflad
Update CHANGELOG for #5269
4013f34
@bflad
Copy link
Contributor Author

bflad commented Aug 9, 2018

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @appilon